nhsx / antibody-web

Web application for finger prick covid19 antibody Lateral Flow Tests (LFT) and interpreting results
MIT License
28 stars 10 forks source link

[LDAT-54] Update timer step to match prototype #69

Closed danielburnley closed 4 years ago

danielburnley commented 4 years ago

What:

barnc commented 4 years ago

Yeah that's what I was wondering - can we check the exception type / message if anything else goes wrong then send it to sentry? Just wary of swallowing errors if they press yes.

On Tue, Jul 7, 2020 at 2:31 PM Daniel Burnley notifications@github.com wrote:

@danielburnley commented on this pull request.

In client/src/components/TestRun/ContentComponent/Wait.tsx https://github.com/nhsx/antibody-web/pull/69#discussion_r450865492:

   if (testRecord && !testRecord.timerStartedAt) {
  • let notificationSubscription: PushSubscription | undefined;

  • try {

  • notificationSubscription = await createNotificationSubscription();

  • } catch (e) {

  • console.log(e);

Maybe? It'd trigger every time someone had said "No" to notification subscriptions though 😬 wasn't sure how best to handle this for now

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nhsx/antibody-web/pull/69#discussion_r450865492, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLQLUYLOTOBEFG5IWDGRD3R2MPSBANCNFSM4ORXJOKA .

danielburnley commented 4 years ago

@barnc I can have a quick look at least, see if i can figure out the error that gets thrown when a user says no and then bubble the rest :tada:

barnc commented 4 years ago

Looks good!