[LDAT-54] Update to match prototype: Pictures & Step counter

nhsx / antibody-web

Web application for finger prick covid19 antibody Lateral Flow Tests (LFT) and interpreting results

MIT License

28 stars 10 forks source link

[LDAT-54] Update to match prototype: Pictures & Step counter #72

Closed danielburnley closed 4 years ago

danielburnley commented 4 years ago

Context

The update to the prototype included updated assets & a removed step counter, this brings the application inline

Changes proposed in this pull request

Add new assets
Update the assets on the screens
Remove programmatically generated steps in favour of hardcoded steps, as there are less of them

Guidance to review

Check out the code and run through the sequence

Link to Jira task

https://bluesquirrel.atlassian.net/browse/LDAT-54

chrimesdev commented 4 years ago

Hey @danielburnley maybe one for the designers, but I wonder if the images could be SVGs? They are vector images so will result in higher quality, especially on retina devices, and there would be web performance benefits in file size and less assets to download (if they were inline SVGs)

danielburnley commented 4 years ago

:wave: hey @AdamChrimes - Yeah that's a good point, I hadn't considered SVGs as an option (our prior assets weren't very SVG-able). I'll see if it's a possibiity