nhsx / antibody-web

Web application for finger prick covid19 antibody Lateral Flow Tests (LFT) and interpreting results
MIT License
28 stars 10 forks source link

LDAT-30 image quality checks #73

Closed barnc closed 4 years ago

barnc commented 4 years ago

Context

We want to be able to drop in audere's ml model with minimal issues when we receive it, and as we have aligned on a spec we can now mock that in

Changes proposed in this pull request

Instead of hitting their old ml model this returns a mocked resopnse which is passed to the client and parsed to give the user the correct error messages. Inspects the user's login id for the strings 'blur', 'over', 'under', 'overunder' and will return those quality statuses from the mock.

Guidance to review

Check api response makes sense before finalising with audere, or anything that might be missing / useful.

Link to Jira task

https://bluesquirrel.atlassian.net/browse/LDAT-30