nhsx / antibody-web

Web application for finger prick covid19 antibody Lateral Flow Tests (LFT) and interpreting results
MIT License
28 stars 10 forks source link

[LDAT-260] AWS Cognito Infrastructure #94

Closed danielburnley closed 4 years ago

danielburnley commented 4 years ago

Context

We are initially using our Cognito as our identity provider, and although we have this setup manually (frontend implemented in #93) we need to set up repeatable infrastructure through Terraform

Changes proposed in this pull request

Link to Jira task

https://bluesquirrel.atlassian.net/browse/LDAT-260

barnc commented 4 years ago

Haven't had a look through this yet, but just to throw a spanner in the works - our cognito authoriser is currently set up in serverless, as its ID needs to be referenced by the functions it applies to - and it currently has a hard coded user pool arn in it.

If we're sticking to the terraform / serverless split, then we'll need to work out how to share that arn from our tf output to serverless.yml. Just a thought!

danielburnley commented 4 years ago

Hmm - Can we make it an environment variable for now? I can add the ARN as an output variable so it's easy to grab manually for now and then we can look at if there's a way to share it automatically in the future