nhsx / old-nhsx-website

:warning: This repository has been deprecated and is now read only
MIT License
18 stars 8 forks source link

added cookie updates in line with nhsuk script update #36

Closed bradmorton1 closed 5 years ago

bradmorton1 commented 5 years ago

Description

This change is needed to be in line with the new cookie consent changes on nhs.uk. It supports the new consent rules (A user only consents by changing and saving their settings now).

See - https://github.com/nhsuk/cookie-consent/commit/d21d0daec661ec04586e356e4c1736e7af588d94 for the corresponding change

Related issue

Checklist

chrimesdev commented 5 years ago

Hi @bradmorton1, please would you be able to add an entry to the change log (date field can be today) and bump the version in package.json and package-lock.json to 1.1.3?

I’ll get this into the develop environment today.

I think there could be a future risk with breaking changes with the cookie script not being versioned on assets.nhs.uk - may consider self hosting the JavaScript.

chrimesdev commented 5 years ago

Looks good - do you know if this cookie consent release includes the fix for the success banner link hover colour that was done a while ago?

If so I'm going to remove this hotfix styling: https://github.com/nhsx/nhsx-website/blob/develop/app/styles/nhsx/_utilities.scss#L66