nhsx / standards-registry

The service powering the NHS standards directory
https://data.standards.nhs.uk
MIT License
4 stars 5 forks source link

[STAN-1110] always create node_modules #329

Closed roc closed 2 years ago

roc commented 2 years ago

Deploy dev fails with an EACCESS issue for creating node_modules: https://github.com/nhsx/standards-registry/actions/runs/3409968479/jobs/5672369479#step:6:64

This creates and chowns the node_modules folder before running the usual installation steps

lennym commented 2 years ago

I think this might cause issues when running npm ci since I think that command will run in the root, and there won't be a package.json or package-lock.json file.

This is how we do it for ASL. And then the install bit looks like this.

As an aside, it might be good to run docker build as part of the CI on PRs and branches.

lennym commented 2 years ago

My example made unnecessarily confusing by naming both the user and directory app. Sorry about that.