Closed Killusions closed 3 years ago
@nhtua Thanks for the quick answer, I fixed your issue.
@nhtua I also added an option for an alternative camera, as in a system with a ton of virtual cams (like mine), it's necessairy in case the main camera is for example unplugged.
@nhtua Any issues on this? I cannot view the changes you requested because I pushed the commits again.
Hey @Killusions Thanks for reminding me. Just checked the PR, code looks neat now. But I found a small issue. Drop list only has one default
value. It only updates the full Camera list after I hit the button Reload
.
I have only one Camera in my system, so I can't check what if it works with default
values or not. Could you help to verify? if it works as expected, please infirm me. I'm happy to merge.
Anyways, thanks for your help on this. You're superb!
Hey @Killusions Thanks for reminding me. Just checked the PR, code looks neat now. But I found a small issue. Drop list only has one
default
value. It only updates the full Camera list after I hit the buttonReload
. I have only one Camera in my system, so I can't check what if it works withdefault
values or not. Could you help to verify? if it works as expected, please infirm me. I'm happy to merge.
@nhtua Thank you for your review. I could reproduce this when the camera permission is not yet given. I pushed a simple fix for it.
Closes #15
Adds webcam selection. Due to browser limitations this does not work locally.