search

nhtua / greencam

a virtual green backdrop for OBS Studio
Apache License 2.0
195 stars 22 forks source link

feat: add webcam selection #17

Closed Killusions closed 3 years ago

Killusions commented 3 years ago

Closes #15

Adds webcam selection. Due to browser limitations this does not work locally.

Killusions commented 3 years ago

@nhtua Thanks for the quick answer, I fixed your issue.

Killusions commented 3 years ago

@nhtua I also added an option for an alternative camera, as in a system with a ton of virtual cams (like mine), it's necessairy in case the main camera is for example unplugged.

Killusions commented 3 years ago

@nhtua Any issues on this? I cannot view the changes you requested because I pushed the commits again.

nhtua commented 3 years ago

Hey @Killusions Thanks for reminding me. Just checked the PR, code looks neat now. But I found a small issue. Drop list only has one default value. It only updates the full Camera list after I hit the button Reload. I have only one Camera in my system, so I can't check what if it works with default values or not. Could you help to verify? if it works as expected, please infirm me. I'm happy to merge.

2021-06-22_16-37

nhtua commented 3 years ago

Anyways, thanks for your help on this. You're superb!

Killusions commented 3 years ago

Hey @Killusions Thanks for reminding me. Just checked the PR, code looks neat now. But I found a small issue. Drop list only has one default value. It only updates the full Camera list after I hit the button Reload. I have only one Camera in my system, so I can't check what if it works with default values or not. Could you help to verify? if it works as expected, please infirm me. I'm happy to merge.

2021-06-22_16-37

@nhtua Thank you for your review. I could reproduce this when the camera permission is not yet given. I pushed a simple fix for it.