nhtua / greencam

a virtual green backdrop for OBS Studio
Apache License 2.0
195 stars 22 forks source link

Add editor #9

Closed CCInc closed 3 years ago

CCInc commented 3 years ago

You can try out the editor file, it should allow you to change all parameters of the model. It'll spit out a url that you can then use for the "player.html" which you input into OBS. I'll check for bugs and update the docs later 👍 Works great for me in OBS.

Let me know what you think!

CCInc commented 3 years ago

In #6 he changes the netowrk to segmentMultiPerson, I reverted it back in this PR but I'm curious what the usecase is for that instead of segmentPerson. Segmentperson should still detect multiple people and create a single mask, and it will be faster.

nhtua commented 3 years ago

Double-checked the official document.

Given an image with one or more people, person segmentation predicts segmentation for all people together. It returns a PersonSegmentation object corresponding to segmentation for people in the image. It does not disambiguate between different individuals. If you need to segment individuals separately use segmentMultiPerson (the caveat is this method is slower).

You're right! I guess edurenye was confused by the name segmentMultiPerson. Multi here is not about "people" but it's is multi segments data. In GreenCam, we don't actually need segmentMultiPerson.

CCInc commented 3 years ago

@nhtua I updated with the changes, let me know your thoughts. In the future I can improve the UI and make some other tweaks, but it's functional for now.

nhtua commented 3 years ago

Tested, It works wells. I'm going to merge now. I will rewrite some document later.