search

nhu313 / Quinn

XML parser for Elixir
Other
49 stars 12 forks source link

Add the ability to parse xml without namespaces/key prefix #9

Closed Kazakbai closed 6 years ago

Kazakbai commented 6 years ago

Hi Nhu Nguyen, recently performing the task of compressing xml data from one service and a problem occurred when parsing data. namely with key prefixes. They changed from time to time, for example, the key was , after a time it changed to , etc. Therefore there was a need to parse without key prefixes.

nhu313 commented 6 years ago

Hi @Kazakbay, thank you for the contribution. I love getting PR ❤️ Do you mind giving me a sample of your xml and the expected result so I can write up a test for it. While I am making an update, I'm going to add to your PR so it will handle the comments too. Thanks again for the PR.

Kazakbai commented 6 years ago

Hi @nhu313, added to README how to parse xml without namespaces and there is an sample with xml

nhu313 commented 6 years ago

Hi @Kazakbay, thanks for the quick reply. The code looks good. I am going to add more to it and make send second params an option map so I can add in the functionality to parse comments. After that, I should be able to merge the code in this weekend. Thank you again for the contribution :)

Kazakbai commented 6 years ago

Good luck!