search

nhubaotruong / league-of-legends-linux-garena-script

85 stars 11 forks source link

updated README.md for new lol and some grammatical changes #10

Closed WasteOfO2 closed 3 years ago

WasteOfO2 commented 3 years ago

-Added link to instructions for getting wine-615 -Updated installation and running instructions for better clarity -Fixed a few grammatical errors here and there

nhubaotruong commented 3 years ago

I don't think we'll need to get that custom wine-615 version, lutris just updated lutris-ge-lol that can start the game already

WasteOfO2 commented 3 years ago

I don't think it has pushed for all distros yet. reinstalling LoL helps Also, can you link me the GH for lutris-ge-lol found it nvm

Other than that, there are a few other changes in README.md

nhubaotruong commented 3 years ago

I don't have the link, but it's available in lutris -> Manage runners -> Manage Versions. You can just download from there.

The other changes looks good to me

WasteOfO2 commented 3 years ago

Yeah i figured it out, LoL loads much faster now compared to the older lutris-lol-5.5-2, so thats great

I may push more changes with perhaps more screenshots in a bit, since I hurriedly made a PR before class, just wanted to iron out a few minor issues before i forget them :P

nhubaotruong commented 3 years ago

So can you fix this MR later or can I remove the wine-615 line and then merge now ?

WasteOfO2 commented 3 years ago

Upto u tbh, u can remove the wine-615 line

ig u can merge rn, i will make another MR when i am free and try to make more changes later.

Maybe I should include instructions for managing runners too as that may help in the future

nhubaotruong commented 3 years ago

Thanks, I'll merge it after lunch

WasteOfO2 commented 3 years ago

alr cool