[Assignment 1] Review

[minhchau273]

Hi Nhung,

I cannot install pod in your project. Can you double check?

-Chau

[minhchau273]

Something went wrong with your pod. I have to delete Podfile.lock, *.xcworkspace and Pods folder then run pod install again. Everything works well now.

[minhchau273]

:+1: Nice work. I really enjoy your indicator shown at the first run time. 🌟 The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Good
• Code Style: Excellent
• Visual Design: Average

Overall: Good

Detailed Notes

• Great clean code. Good job utilizing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Nice work implementing the error message on network failure. You have to create your own error message instead of using the alert controller. We mentioned it in the requirements. (You may not use UIAlertController or a 3rd party library to display the error.). One more thing, you should edit the alert message here.
• It'd be better if you set the icons for the tab bars.
• It's a little bit hard to read the overview in details screen. Why did you put the overview here though you have a large white space below the poster?
  
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• 👍 for using auto layout.

Thanks for spending so much time on the homework! If you ever get stuck, please ask as many questions as you can.