search

nhungnguyen123 / Coder_School

0 stars 0 forks source link

Thanks! #1

Open coderschoolreview opened 7 years ago

coderschoolreview commented 7 years ago

Thank you for your Android submission, Nhung Nguyen!

😇 Everything looks good with the format of your submission. We'll be reviewing your submission soon! :sunglasses: Could you please update README file by checking what you've done (follow the pre-work guides)

coderschoolreview commented 7 years ago

Hey Nhung,

Thanks so much for your submission. This is a great start! it seems like you got a pretty good hang of the basics with Android. However, we would love to see some additional time spent to fix some of the issues mentioned below.

The good stuff:

Needs work:

nhungnguyen123 commented 7 years ago

I fixed the issues . Please check it again when you have free time . Thank you so much . @coderschoolreview

kungfoolabs commented 7 years ago

Hey Nhung! Thanks for taking time to fix the issues. The code works!

We did notice that you are using some pretty advanced libraries. Nothing wrong with the approach. Out of curiosity, is there a reason that you decided to take this direction versus building some components out from scratch?

nhungnguyen123 commented 7 years ago

Hey @kungfoolabs , Thank for your question . About why I decided to take this direction versus building some components out from scratch . Because, I recently know about CoderSchool and when I start my pre- work so late and after I came back my house for Tet holiday . And when I received issue from CoderSchool , My laptop dis broken and I need to fix the issues at my office by computer of company. I need to fix issues before deadline . I can not take more time for pre - work at my office . Before , I know some libraries to complete requirement. And I apply it for my pre- work . I know , my pre - work have many trouble . Thank you about your question . Do not hesitate when you have any question . Just ask. 👍

coderschoolreview commented 7 years ago

Thank you, Nhung Nguyen. Let's schedule a quick call to confirm that this course is a right fit for you. We also would like to know a little more about your experience. Please book a slot from here.

nhungnguyen123 commented 7 years ago

Thank you , @coderschoolreview https://github.com/coderschoolreview. About my experience. I recently graduate University. Before, I have one year is internship android developer at one company has name is HORICAL. And after that I start one product with my co - worker for restaurant manager . After about 5 month , our product must stop because did not have enough money to spend for my team . I find new job, I apply to QA position of one company from Danmak . And I am QA at redWEB company about 3 months , but I know , I really like code more than QA. I want to join in CodeShool class and improve my code skill and find new job fit to me . In fact , I really want to create product and sell it and make it bring the value.

On Thu, Feb 9, 2017 at 7:37 PM, coderschoolreview notifications@github.com wrote:

Thank you, Nhung Nguyen. Let's schedule a quick call to confirm that this course is a right fit for you. We also would like to know a little more about your experience. Please book a slot from here https://calendly.com/harley/15m.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nhungnguyen123/Coder_School/issues/1#issuecomment-278849412, or mute the thread https://github.com/notifications/unsubscribe-auth/ANCufzk5Nnhhhr6EWUE0hFt0xiwBKgXoks5ra9uRgaJpZM4L2BBe .