search

nhurel / terraspec

Terraform unit test framework
Mozilla Public License 2.0
79 stars 7 forks source link

Add support for workspaces + mac support + terraform 0.13 #5

Closed tomelliot16 closed 3 years ago

tomelliot16 commented 4 years ago

I manually tested this patch and it worked on mac. Also workspace feature works like a charm. I think might look at the next issue I opened. https://github.com/nhurel/terraspec/issues/4. Also I've just started using golang so being critical won't scare me away. I'd rather we have good sustainable code 😄 .

tomelliot16 commented 4 years ago

@nhurel the only reason I combined the two PRs was to be able to test directly on mac which requires 0.13 with golang 1.14. I can isolate the change for workspace support as so as the feature is finalized.

Useurmind commented 4 years ago

Can I help to make progress on this feature? We would like to use the tool, but we need the workspace support.

nhurel commented 4 years ago

As i've merged terraform 0.13 upgrade to master already, this PR would need to resolve conflicts first. I think once done, the PR should only contain what's needed to add support for mocking terraform workspace. Apart some improvement on the tests, the PR looked okay to me