nhuthm-setel / df-frontend-2023

https://nhuthuynh-df-frontend-2023.vercel.app
0 stars 0 forks source link

Submission for assignment 3 #9

Open nhuthm-setel opened 1 year ago

nhuthm-setel commented 1 year ago
zlatanpham commented 12 months ago

Hello @nhuthm-setel, good work!

Requirements

Final result: ✅ passed 70% of the requirements

Feedback

We also have some comments for your work:

  1. There is no need to explicitly specify the type of the initial value passed in the state, as TypeScript has the ability to infer it. https://github.com/nhuthm-setel/df-frontend-2023/blob/ac03627f836091fcf03de1a31e8ed5d64e8a3cbb/assignment-3/src/App.tsx#L19
  2. As per the comment in assignment 01, using a button can help avoid the need for enforcing a11y attributes. https://github.com/nhuthm-setel/df-frontend-2023/blob/ac03627f836091fcf03de1a31e8ed5d64e8a3cbb/assignment-3/src/components/BookList.tsx#L96-L108
  3. Binding the keyDown event in that way is somewhat redundant. https://github.com/nhuthm-setel/df-frontend-2023/blob/ac03627f836091fcf03de1a31e8ed5d64e8a3cbb/assignment-3/src/components/BookList.tsx#L53-L56