search

nhynes / jwk-rs

Rust JSON Web Keys 🦀🕸🔑
MIT License
33 stars 17 forks source link

Allow any String as Key Use #9

Open maxlambrecht opened 2 years ago

maxlambrecht commented 2 years ago

Solves #8

nhynes commented 2 years ago

This looks good. Thanks for the PR. I proposed a few modifications around keeping KeyUse as an enum so that the two named in the spec are more convenient and harder to mis-type. Let me know if this interface will work for you.

Either option here is a breaking change, so this'll need to go out with a v0.4.* of this crate. I'd like to batch it up with some changes I'm about to make, if you wouldn't mind waiting. If it's a priority for you, I can make a fresh v0.4.0 with just this change.

maxlambrecht commented 2 years ago

This looks good. Thanks for the PR. I proposed a few modifications around keeping KeyUse as an enum so that the two named in the spec are more convenient and harder to mis-type. Let me know if this interface will work for you.

Looks good to me! It makes sense to keep the enum types for those two uses mentioned in the spec.

Either option here is a breaking change, so this'll need to go out with a v0.4.* of this crate. I'd like to batch it up with some changes I'm about to make, if you wouldn't mind waiting. If it's a priority for you, I can make a fresh v0.4.0 with just this change.

No worries, I can wait.

Thanks!

maxlambrecht commented 2 years ago

Hi @nhynes, do you have an ETA for this PR?