nhzaci / pe

0 stars 0 forks source link

Misleading error message on interger overflow for deletecontact command #8

Open nhzaci opened 3 years ago

nhzaci commented 3 years ago

Steps to reproduce:

  1. Type deletecontact 10000
  2. Type deletecontact 100000000000000000

Expected:

Actual:

Screenshots:

Screenshot 2021-04-16 at 2.54.20 PM.png

Screenshot 2021-04-16 at 2.54.29 PM.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Misleading error message for integer overflow error on deletenote command

Steps to reproduce:

  1. Type deletenote 10000
  2. Type deletenote 100000000000000000

Expected:

  • Error should say invalid index or at least say that the error is vaused by an integer overflow, rather than invalid command.

Actual:

  • Error output simply says invalid command format, even though the format is correct but it's just the interger that's overflowing

Screenshots:

Screenshot 2021-04-16 at 2.47.40 PM.png

Screenshot 2021-04-16 at 2.47.53 PM.png


[original: nus-cs2103-AY2021S2/pe-interim#1415] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

first of all, the bug is introduct because max integer is 2147483647.

hence, the index you have entered is not an integer.

Furthermore, while the test case is extreme, I do not think it will ever happen unless people intentionally mess with it

While it a bug, I do not think a user will have more than 2 million note, this case is near impossible to happen in a realistic scenario.

Accepted, however we think that this is VeryLow severity

All the bug are duplicate because they all use the same parser and can be fixed together with one changes. All bug originates from this method

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]