search

ni / VireoSDK

Compact runtime for a subset of LabVIEW
Other
49 stars 44 forks source link

Fix ByteArrayNode WebVI error code to match Desktop #672

Closed tatwood2 closed 4 years ago

tatwood2 commented 4 years ago

A developer noticed that the error code for the Web ByteArray node was 1 while desktop is 1396 (AzDo bug 1068756). This change switches the error code and updates the tests.

tatwood2 commented 4 years ago

This is to fix https://ni.visualstudio.com/DevCentral/_workitems/edit/1068756. The bug only mentions changing the error code, not modifying the message string to match desktop. When this vireo change makes it to master, I'll need to update the test mentioned there at the same time.

rajsite commented 4 years ago

It might be overkill for this specific PR but to get familiar with the workflow can you please include a link to the ASW draft PR with the ASW tests and run a npm pack build against the Web Module Squad tests.

Once the PR is approved on GitHub the changes will be merged and a new release made to integrate to the ASW PR.

sanmut commented 4 years ago

This is to fix https://ni.visualstudio.com/DevCentral/_workitems/edit/1068756. The bug only mentions changing the error code, not modifying the message string to match desktop. When this vireo change makes it to master, I'll need to update the test mentioned there at the same time.

It is a good idea to include the name of the node in the error message to match Desktop behavior while you are at it. Example: SetErrorAndAppendCallChain call using the name of the node "Variant To Data" correctly.

sanmut commented 4 years ago

Great, thanks for fixing this :-)