search

ni / VireoSDK

Compact runtime for a subset of LabVIEW
Other
49 stars 44 forks source link

Make RegisterForEvents not error in some cases #674

Closed tatwood2 closed 4 years ago

tatwood2 commented 4 years ago

Sankara and Craig decided that one way to fix AzDo bug 1066414 (https://ni.visualstudio.com/DevCentral/_workitems/edit/1066414) was to just not error out in Vireo in this case. There's still some work to do in Dfir that will be a separate PR.

Here's the VireoTest results: https://ni.visualstudio.com/DevCentral/_build/results?buildId=432727&view=results

tatwood2 commented 4 years ago

See comments from Craig and Sankara here: https://github.com/sanmut/VireoSDK/commit/4cd8e031b297a28258f71349a7b22b5aaefc3c44#r40563830

rajsite commented 4 years ago

Please include a link to a passing VireoTest CI build in the PR description (okay if you're waiting for feedback, just a reminder)

cglzaguilar commented 4 years ago

Please address Milan's feedback.

tatwood2 commented 4 years ago

Please include a link to a passing VireoTest CI build in the PR description (okay if you're waiting for feedback, just a reminder)

Yes, I haven't kicked it off yet (still writing a test driver test before I could submit). I'll go ahead and push to get the VireoTarget tests running immediately instead of waiting until Monday.

The latest run of the Vireo tests (with these changes) passed: https://ni.visualstudio.com/DevCentral/_build/results?buildId=433910&_a=summary&view=results

@rajsite, this is ready to be checked in.