search

ni / actor-framework

Open source repo for Actor Framework
MIT License
4 stars 2 forks source link

Package 2.0.0.8 installation fails on PreInstall.vi #3

Closed MathieuR-Iolas closed 4 weeks ago

MathieuR-Iolas commented 1 month ago

I tried to install the package actor_framework_2024_for_2020-2.0.0.8.vip (from Builds folder in Cleanup branch).

I saw the LabVIEW loading dialog box, looking for Stash Framework.vi image

And I finally get an error: image

It seems to be a known behavior: custom actions VIs cannot use sub-VIs that are not already installed by the package. So when installing actor_framework_2024_for_2020-2.0.0.8.vip, the content of the folder Install Support has not yet been copied to their destination. And cannot be loaded by PreInstall.vi.

I get the exact same behavior with LabVIEW 2023 64-bits and LabIVEW 2021 SP1 32-bits.

I suppose (not tested) that this issue will impact the exact same way the PostInstall custom action.

One suggestion could be to set content of the sub-VIs directly in Pre-Install VI (no more sub-VIs calls, lowering readability and maintenability). A more complex approach could be to create a support package, and set it as dependency of actor_framework_2024_for_2020-2.0.0.8.vip: in my understanding, dependencies are supposed to be installed before by VIPM

MathieuR-Iolas commented 1 month ago

With the following diagram, the zip file is created as expected at package installation:

Pre-Install Custom Action

niACS commented 1 month ago

This will be fixed once my current pull requests have been processed. The correct build will be 2.0.0.12 (1.0.0.8 if you are looking at the main branch).