search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

introduced new step to trigger new pipeline, should eventually replace all other steps #1006

Closed christag-ni closed 1 year ago

christag-ni commented 1 year ago

What does this Pull Request accomplish?

Introduces a new step that will trigger new pipeline in azdo(not yet created)

Why should this Pull Request be merged?

This new step is required to trigger the new azdo pipeline

What testing has been done?

No testing

This pr shouldn't be completed until this PR is completed and we're able to create a new pipeline utilizing the new pipeline-ci.yml

christag-ni commented 1 year ago

@reckenro @astarche The run_ubuntu_system_tests is failing with this in it's raw logs 2023-10-12T00:05:38.2374509Z unknown file: Failure 2023-10-12T00:05:38.2379249Z C++ exception with description "Insufficient location information or the device or resource is not present in the system." thrown in SetUp(). 2023-10-12T00:05:53.4804235Z /opt/actions-runner/_work/_temp/fc5d9653-2083-4df6-afca-26e435446749.sh: line 1: 2759 Segmentation fault (core dumped) ./SystemTestsRunner --gtest_filter=-NiRFSA*:NiRFSG*:NiDCPower*CalSelfCalibrate* 2023-10-12T00:05:53.4827488Z ##[error]Process completed with exit code 139.

I'm not sure how to determine what the problem is. Could either of you help me determining what this could be?

bkeryan commented 1 year ago

@reckenro @astarche The run_ubuntu_system_tests is failing with this in it's raw logs 2023-10-12T00:05:38.2374509Z unknown file: Failure 2023-10-12T00:05:38.2379249Z C++ exception with description "Insufficient location information or the device or resource is not present in the system." thrown in SetUp(). 2023-10-12T00:05:53.4804235Z /opt/actions-runner/_work/_temp/fc5d9653-2083-4df6-afca-26e435446749.sh: line 1: 2759 Segmentation fault (core dumped) ./SystemTestsRunner --gtest_filter=-NiRFSA*:NiRFSG*:NiDCPower*CalSelfCalibrate* 2023-10-12T00:05:53.4827488Z ##[error]Process completed with exit code 139.

I'm not sure how to determine what the problem is. Could either of you help me determining what this could be?

It's failing in VisaMessageBasedLoopbackTest.

@danielhuani @dmondrik 

[----------] 15 tests from VisaMessageBasedLoopbackTest
[ RUN      ] VisaMessageBasedLoopbackTest.WriteAndRead_Matches
[       OK ] VisaMessageBasedLoopbackTest.WriteAndRead_Matches (4 ms)
[ RUN      ] VisaMessageBasedLoopbackTest.WriteAsyncAndReadAsync_Matches
[       OK ] VisaMessageBasedLoopbackTest.WriteAsyncAndReadAsync_Matches (3 ms)
[ RUN      ] VisaMessageBasedLoopbackTest.WriteTwice_ReadOnce_Matches
[       OK ] VisaMessageBasedLoopbackTest.WriteTwice_ReadOnce_Matches (3 ms)
[ RUN      ] VisaMessageBasedLoopbackTest.ReadMoreThanWritten_ReturnTimeoutErrorWithDataInResponsePacket
unknown file: Failure
C++ exception with description "Insufficient location information or the device or resource is not present in the system." thrown in SetUp().
/opt/actions-runner/_work/_temp/fc5d9653-2083-4df6-afca-26e435446749.sh: line 1:  2759 Segmentation fault      (core dumped) ./SystemTestsRunner --gtest_filter=-NiRFSA*:NiRFSG*:NiDCPower*CalSelfCalibrate*
Error: Process completed with exit code 139.
christag-ni commented 1 year ago

@danielhuani @dmondrik I'm not sure if this is actively being looked into, but is there something I can do to stop this failing test from blocking my PR?

dmondrik commented 1 year ago

@danielhuani @dmondrik I'm not sure if this is actively being looked into, but is there something I can do to stop this failing test from blocking my PR?

It turns out the system test failure does not block your PR. You can submit despite it.

danielhuani commented 1 year ago

@danielhuani @dmondrik I'm not sure if this is actively being looked into, but is there something I can do to stop this failing test from blocking my PR?

@christag-ni The VISA test failure on Ubuntu is a known issue, I am working on the grpcbot-ubuntu build to let it install ni-visa. Please be aware that the system test failure won't stop your PR from getting committed.

christag-ni commented 1 year ago

@astarche @reckenro The first attempt at using the new step failed because of the unexpected input "azure-pipeline-variables". Is there a list somewhere where we validate specific inputs?

reckenro commented 1 year ago

@astarche @reckenro The first attempt at using the new step failed because of the unexpected input "azure-pipeline-variables". Is there a list somewhere where we validate specific inputs?

@christag-ni , ah I think it's because we're using Azure/pipelines@v1 which didn't have that azure-pipeline-variables. If you bump it to v1.2, it should have it. Comparing v1 to v1.2 shows PR 11 adding the functionality for those pipeline variables: https://github.com/Azure/pipelines/compare/v1...v1.2

And the other NI repos seem to already be using that v1.2 version so bumping it for gprc-device should be fine: https://github.com/search?q=org%3Ani%20Azure%2Fpipelines%40&type=code