Code generation could be more efficient for simple 'repeated' types - Githubissues

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.

MIT License

71 stars 50 forks source link

Code generation could be more efficient for simple 'repeated' types #1011

Open dmondrik opened 1 year ago

dmondrik commented 1 year ago

In many cases a vector is declared on the stack and the data is copied unnecessarily. Examples:

The input int32 array of values in NiRFmxInstrService::SetAttributeI32Array
The output float64 array stateVector in NiDAQmxService::GetAnalogPowerUpStates

In at least some cases like this, we should be able to generate code that efficiently:

For input, gets the pointer to the request buffer's data()
For output, gets the mutable data and reserves the appropriate size.