search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

Removed the Initialize Api with channel parameter #1017

Closed alenkani closed 1 year ago

alenkani commented 1 year ago

What does this Pull Request accomplish?

we have decided to remove the the API "RFmxInstr_InitializeWithChannel " Channel information from separate parameter is not expected now. hence we need to remove the added Initialize API from both C and .NET The RFSA/G Driver has decided not to expose this API, contrary to the previous plan of making it public. In light of this decision, RFmx will also refrain from exposing it.

Why should this Pull Request be merged?

https://dev.azure.com/ni/DevCentral/_workitems/edit/2548517/

What testing has been done?

Locally built grpc-device.

astarche commented 1 year ago

Marking binary-breaking. Removing an API is binary breaking because existing compiled clients that use the API will break when targeting new servers. "source breaking" changes are something like "renaming fields" where existing compiled clients continue working (the binary format on the wire is the same) but will need to update when they re-run protoc.