search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

RFmxSpecAn Update to 24.0 #1029

Closed alenkani closed 11 months ago

alenkani commented 11 months ago

What does this Pull Request accomplish?

Updates niRFmxSpecAn in grpc-device to 24.0 Updated manually niRFmxSpecAn_exclude.h file to skip property specific Set/Get APIs as per the design.

Why should this Pull Request be merged?

Updated to match the upcoming release of niRFmxSpecAn 24.0.0 There are Lot of apis rearranged because of Code clean Up in header file

What testing has been done?

Manually inspected generated files. Copied files from grpc-device-scrapigen/out/rfmxSpecAn/export/ to grpc-device/source/codegen/metadata/nirfmxSpecAn/ and built grpc-device successfully. Manually inspected nirfmxspecan.proto file.

alenkani commented 11 months ago

I see changes to attributes/functions in this change. But the pending PR in scrapgien with the same description has no changes in the export directories. Can you sync those up or help me figure out what I'm missing?

The changes in Export are already submitted to scrapigen in this pr https://github.com/ni/grpc-device-scrapigen/pull/203/files#diff-e6e39b907c46a8add9ed73a85a7a0dee088ce9a945ec7180a7527866dd8ac7c5