search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

Updated grpc device code for ModSpectrum APIs and Attributes #1037

Closed Udeepchandra closed 8 months ago

Udeepchandra commented 9 months ago

What does this Pull Request accomplish? Updates niRFmxBT in grpc-device to 24.3 Updates the Grpc Device Code for Mod spectrum APIs and attributes. Updates the Grpc Device Code for Channelsoundingsyncsequence attribute enum update to payload pattern

Why should this Pull Request be merged? Updated to match the upcoming release of niRFmxBt 24.3.0

What testing has been done? Manually inspected generated files.. Manually inspected nirfmxbluetooth.proto file

Udeepchandra commented 9 months ago

This will match the Upcoming RFmx 24.3 BT Release.

Udeepchandra commented 9 months ago

Can you update config.py and the README to bump the RFmx BT version to 24.3?

Updated the Version.

Udeepchandra commented 9 months ago

Looks good. FYI there's a Bug right now preventing submission in the repo (it's what's causing the validate_python step to fail). You'll have to wait for that to go in before getting a passing build and ability to merge.

Update: That bug was fixed but I think you'll have to merge main to get those fixes into this branch and the CI build to pass.

Looks good. FYI there's a Bug right now preventing submission in the repo (it's what's causing the validate_python step to fail). You'll have to wait for that to go in before getting a passing build and ability to merge.

Update: That bug was fixed but I think you'll have to merge main to get those fixes into this branch and the CI build to pass.

The Python Validation step is now passed Successfully. Looks like the CI/build_desktop/Windows Build Required step failed.

reckenro commented 9 months ago

The Python Validation step is now passed Successfully. Looks like the CI/build_desktop/Windows Build Required step failed.

Oh sorry, I should've mentioned this when you updated config.py. It'll cause the .proto to be updated with that new version at the top of the file. So you'll need to rebuild locally and push up the changed .proto file so the build doesn't complain about a mismatch between what's in the branch's generated folder and what the CI build produces.

Udeepchandra commented 9 months ago

@maxxboehme Can you review this PR as this PR is being hold from long time because your review is pending on this