search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

Updated gRPC Device code for all 24C1 RFmx APIs #1047

Closed RahulBenaka closed 7 months ago

RahulBenaka commented 8 months ago

gRPC Supported personalities - BT, LTE, NR, SpecAn and WLAN

What does this Pull Request accomplish? Updates niRFmxSpecAn in grpc-device-scrapigen to 24.3.0 Updates niRFmxLTE in grpc-device-scrapigen to 24.3.0 Updates niRFmxNR in grpc-device-scrapigen to 24.3.0 Updates niRFmxWLAN in grpc-device-scrapigen to 24.3.0 Updates the gRPC Scrapigen Device Code for SpecAn Marker APIs. Updates the gRPC Scrapigen Device Code for LTE List Mode APIs, attributes and enums. Updates the gRPC Scrapigen Device Code for new BT ModSpectrum API and attributes.

Why should this Pull Request be merged? Updated to match the upcoming release of niRFmxSpecAn 24.3.0 Updated to match the upcoming release of niRFmxLTE 24.3.0 Updated to match the upcoming release of niRFmxNR 24.3.0 Updated to match the upcoming release of niRFmxWLAN 24.3.0

What testing has been done? Manually inspected generated files. Copied files from grpc-device-scrapigen/out/rfmxspecan/export/ to grpc-device/source/codegen/metadata/nirfmxspecan/ and built grpc-device successfully. Manually inspected nirfmxspecan.proto file. Copied files from grpc-device-scrapigen/out/rfmxlte/export/ to grpc-device/source/codegen/metadata/nirfmxlte/ and built grpc-device successfully. Manually inspected nirfmxlte.proto file. Copied files from grpc-device-scrapigen\out\rfmxbluetooth\export to grpc-device/source/codegen/metadata/ nirfmxbluetooth / and built grpc-device successfully. Manually inspected nirfmxbluetooth.proto file. Copied files from grpc-device-scrapigen\out\rfmxnr\export to grpc-device/source/codegen/metadata/ nirfmxnr/ and built grpc-device successfully. Manually inspected nirfmxnr.proto file. Copied files from grpc-device-scrapigen\out\rfmxwlan\export to grpc-device/source/codegen/metadata/ nirfmxwlan/ and built grpc-device successfully. Manually inspected nirfmxwlan.proto file. Manually inspected nirfmxbluetooth.proto file.

maxxboehme commented 7 months ago

@RahulBenaka @reckenro @astarche I am reruning the windows tests as they appeared to have failed due to some labview crash.

RahulBenaka commented 7 months ago

@RahulBenaka @reckenro @astarche I am reruning the windows tests as they appeared to have failed due to some labview crash.

I see that all the checks have passed successfully. @astarche @reckenro @maxxboehme Can you please approve the PR? I had reset the vote of approval as I pushed new changes. Sorry for the inconvenience. I need to submit these as soon as possible as it is required for the release.

RahulBenaka commented 7 months ago

@astarche Can you please review the PR? I need this PR to be merged before release branch is created.