search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

Correcting enum values and maintaining backward compatability #1049

Closed RahulBenaka closed 7 months ago

RahulBenaka commented 7 months ago

What does this Pull Request accomplish? Avoids changing a field number in the RFmx LTE Proto from the previous release. Avoids changing a field number in the RFmxSpecAn Proto from the previous release

Why should this Pull Request be merged? Reverses the binary breaking change introduced in https://github.com/ni/grpc-device/pull/1047 Adding the special implementation in the functions_addon.py files of SpecAn and LTE to make sure correct code is generated in future.

What testing has been done? The build.

RahulBenaka commented 7 months ago

@reckenro @astarche @maxxboehme Please review the PR as we have to merge this asap. This is required for the release in both gRPC and RFmx 24.3.0 products

FYI: @ThangamV-NI