search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
69 stars 47 forks source link

Update CMakeLists.txt to 2.6.0 #1050

Closed christag-ni closed 5 months ago

christag-ni commented 5 months ago

What does this Pull Request accomplish?

Bumps the version in CMake file

Why should this Pull Request be merged?

To reflect that the next grpc-device release will be 2.6.0

What testing has been done?

None

christag-ni commented 5 months ago

We should bump the version in AzDo first, then we can bump here. Otherwise, if this goes into main as is it'll create another 2.5 adhoc export.

Wouldn't doing it in this order mean that, for a small moment, ni-central will be pulling in a version of grpc-device that doesn't yet have builds?

reckenro commented 5 months ago

We should bump the version in AzDo first, then we can bump here. Otherwise, if this goes into main as is it'll create another 2.5 adhoc export.

Wouldn't doing it in this order mean that, for a small moment, ni-central will be pulling in a version of grpc-device that doesn't yet have builds?

I don't think so, ni-central is only notified of builds from grpc-device. Changes on the ni-central side won't trigger the pipeline to run that pulls from grpc-device for a new adhoc export (see here in the pipeline file).

christag-ni commented 5 months ago

@reckenro AzDO changes have been merged https://ni.visualstudio.com/DevCentral/_git/ni-central/pullrequest/681880