search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

Adding private APIs to configure attenuation tables in RFmx Instr #1052

Closed paulolamas18 closed 7 months ago

paulolamas18 commented 7 months ago

What does this Pull Request accomplish?

Expose, in grpc-device, the existing private APIs in RFmxInstr to create and configure attenuation tables.

Why should this Pull Request be merged?

We have a use case for using these private APIs, but they are currently not exposed through NI's gRPC server.

What testing has been done?

Simple program that calls these APIs throws a NotImplemented exception with the currently release server. No errors thrown after these changes.

reckenro commented 7 months ago

@ThangamV-NI , I added you since you edited these restricted proto files most recently but feel free to ignore this or foreword to another reviewer, whichever makes sense.

paulolamas18 commented 7 months ago

Hi @reckenro, "_CI/run_win_system_tests/Run Tests (pullrequest)" has been queued for a while, do you know what might be going on? This is the first time I try to pull a change to this repo.

reckenro commented 7 months ago

Hi @reckenro, "_CI/run_win_system_tests/Run Tests (pullrequest)" has been queued for a while, do you know what might be going on? This is the first time I try to pull a change to this repo.

Oh yes, @paulolamas18 the pipeline that makes the Windows VMs that those system tests run against sometimes has to be kicked off again because this step stalls out. I kicked that off and will re-queue that step once that completes. Should wrap up by the afternoon and then if things look good I'll merge your change in.