search

ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

Add override specifier to inherited library class functions #995

Closed reckenro closed 1 year ago

reckenro commented 1 year ago

What does this Pull Request accomplish?

Add the override specifier to library class functions that exist in the interface class it inherits from.

Why should this Pull Request be merged?

Although we own the parent class, it's generally good practice to use override when you override a method so that you get a compiler error if there's no function to override (usually because the signature of the function in the parent class changes).

What testing has been done?

Built it locally

reckenro commented 1 year ago

Note: This is the same as #965 , but we're trying to see if we can get changes in today and that was in a fork so it wasn't as simple to merge main and regen from there so just duplicating that small library.h.mako change in this new branch and regening.