ni / grpc-device

gRPC server providing remote access to NI device driver APIs.
MIT License
71 stars 50 forks source link

Potential MyPy solutions for new example. #996

Closed reckenro closed 1 year ago

reckenro commented 1 year ago

Purpose

This is just a draft PR to show a potential solution to the MyPy violations being hit in #912 . This is targeted to that branch.

Merged main but the actual changes to fix the MyPy violations in that other PR are the last three commits here: https://github.com/ni/grpc-device/pull/996/files/4b741b1916f3c2b04ecb14889f2184e9c60a3074..159f657090ff99ee9d8354986bf27a544dc34e05

My steps for running MyPy locally

Pre-req

  1. Navigate to main grpc-device repo folder
  2. Run python -m pip install -r python_build_requirements.txt
  3. Run python -m pip install poetry

Validate new nirf example

  1. Build
  2. Navigate to build directory
  3. Run python ..\source\codegen\validate_examples.py -p "*nirf"
reckenro commented 1 year ago

Abandoning since MyPy fixes have been incorporated in #912