I am planning to make changes to the code generators in up coming PRs. Before doing so, I am doing a mass cleanup of the existing VIs in this PR to improve readability and minimize diffs for more meaningful changes in the future.
Implementation
There are no intended functional changes as part of this PR. The changes are purely cosmetic in nature to improve readability. Move control/indicator label to the left/right on the block diagram, uncross wires, and that sort of thing. In some cases, common code was extracted and unreferenced code was deleted. There were a few VIs that didn't have source only setting and those have been fixed as well. I also updated the icon for the error code VIs as a solid red background color doesn't play well with the icon editor algorithm in later LV versions. It tends to display the text over the library banner rather than limiting the text to the area below the banner.
Testing
Manually tested round trip of data between client/server for unary API using repeated message fields.
Manually tested round trip of data between client/server for unary API using oneof field. Filed #396 as a result of this testing. Verified the same behavior is present before these changes. The generated code looks good though.
Description
I am planning to make changes to the code generators in up coming PRs. Before doing so, I am doing a mass cleanup of the existing VIs in this PR to improve readability and minimize diffs for more meaningful changes in the future.
Implementation
There are no intended functional changes as part of this PR. The changes are purely cosmetic in nature to improve readability. Move control/indicator label to the left/right on the block diagram, uncross wires, and that sort of thing. In some cases, common code was extracted and unreferenced code was deleted. There were a few VIs that didn't have source only setting and those have been fixed as well. I also updated the icon for the error code VIs as a solid red background color doesn't play well with the icon editor algorithm in later LV versions. It tends to display the text over the library banner rather than limiting the text to the area below the banner.
Testing