ni / javascript-styleguide

JavaScript and TypeScript Style Guide
MIT License
9 stars 9 forks source link

Ignore constructors in @typescript-eslint/explicit-member-accessibility #100

Open mure opened 2 years ago

mure commented 2 years ago

@typescript-eslint/explicit-member-accessibility by default is forcing us to add public before every constructor, even though 99.9% of the time the implicit public is expected. We could set [ { overrides: { constructors: 'no-public' } } ] to change this: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/explicit-member-accessibility.md#disallow-the-use-of-public-on-a-given-member

jattasNI commented 1 year ago

We agreed not to require public on constructors. We decided to prefer turning off enforcement (to avoid churn) rather than enforcing that there should be no modifier.

@rajsite to own turning this decision into a config change.