Add a TypeScript shareable configuration.

ni / javascript-styleguide

JavaScript and TypeScript Style Guide

MIT License

9 stars 9 forks source link

Add a TypeScript shareable configuration. #12

Closed TrevorKarjanis closed 3 years ago

TrevorKarjanis commented 3 years ago

Add a TypeScript shareable configuration.

Notes

All of the extension rule configurations are based on their core values in the JavaScript configuration.
The parserOptions.project configuration is for rules that require type information.
The process for setting up an Angular workspace is different and will be added later.

Linted and tested

Verified that the configuration works with a standard ESLint workspace
Verified that the configuration works with an Angular workspace

jattasNI commented 3 years ago

Our test suite currently invokes ESLint on the JS files in the repo. Would there be value in adding a placeholder TS file and linting it too? Might be overkill, just a suggestion.

TrevorKarjanis commented 3 years ago

Our test suite currently invokes ESLint on the JS files in the repo. Would there be value in adding a placeholder TS file and linting it too? Might be overkill, just a suggestion.

Yes, I think even a smoke test is valuable. However, that would require a TypeScript configuration and test file which I would like to leave for another PR. This ruleset currently requires type checking whereas @typescript-eslint/recommended separates rules that require types. That is a different discussion altogether.