search

ni / javascript-styleguide

JavaScript and TypeScript Style Guide
MIT License
9 stars 9 forks source link

New Playwright ESLint package #120

Closed jattasNI closed 1 year ago

jattasNI commented 1 year ago

Justification

Fixes #114.

Implementation

  1. Added a new package containing playwright rulesets
    • it exposes regular and requiring-type-checking variants which derive from the base typescript ruleset
    • it adds configurations for rules as discussed in #114
    • updated root README to mention it and describe its configuration
  2. Added smoke tests for the package. I initialized these using Playwright's setup instructions then deleted a bunch of unnecessary stuff since we don't actually execute the Playwright test.
  3. I noticed that the npm run lint command was failing on existing code so I fixed violations (just whitespace) and enabled it in the pipeline.