search

ni / javascript-styleguide

JavaScript and TypeScript Style Guide
MIT License
9 stars 9 forks source link

Revert Angular 15 support #132

Closed mollykreis closed 9 months ago

mollykreis commented 9 months ago

My previous PR (#129) did not simplify the Angular 15 upgrade as I had hoped it would. Instead, it caused more problems because npm is having trouble resolving some of the peer dependencies that need to be installed. Therefore, I am reverting the PR that added Angular 15 support, and I will make a separate PR after this one is merged that changes the Angular support of this package to only Angular 15.

Resolves #131

I've tested this change in an Angular 14 application, and I verified that the updated package can install without requiring any additional dependencies to be configured.

rajsite commented 9 months ago

FYI @jattasNI @TrevorKarjanis @mure straightforward revert of the previous change which added Angular 15 optionally and caused issues externally, merging in to keep the process moving

jattasNI commented 9 months ago

Looks like the new package is being uptaken cleanly.🥳