ni / javascript-styleguide

JavaScript and TypeScript Style Guide
MIT License
9 stars 9 forks source link

Add documentation for configuring ESLint with Angular applications to the README. #26

Closed TrevorKarjanis closed 3 years ago

TrevorKarjanis commented 3 years ago

Notes

Tested

scotia673 commented 3 years ago

FYI: based on some earlier testing, my understanding is that the @angular-eslint tooling is only supported for newer versions of Angular (I think 11+?). Does that jive with your understanding/testing as well? If so, it might be worth calling that out explicitly in the readme.

TrevorKarjanis commented 3 years ago

FYI: based on some earlier testing, my understanding is that the @angular-eslint tooling is only supported for newer versions of Angular (I think 11+?). Does that jive with your understanding/testing as well? If so, it might be worth calling that out explicitly in the readme.

Hey! See the version support documentation. 1.x.x (documentation) supports 10.1.0 to <11.2.0 and is still under development. 2.x.x supports >=11.2.0. However, 3.x.x is under development, and Angular may release 12.0 next month. angular-eslint has seen significant development so the latest version will bring advantages. See the Angular support documentation for a recommendation on where your product might want to be.

I moved from 10 to 11 last week to make this readme, and as usual it was fine. Obviously, I don't want to include all of this information in this readme, but I do agree it would be helpful to include a note.

Thanks for taking the time!