Re-enable @angular-eslint/template/i18n in angular smoke test

ni / javascript-styleguide

JavaScript and TypeScript Style Guide

MIT License

9 stars 9 forks source link

Re-enable @angular-eslint/template/i18n in angular smoke test #64

Closed rajsite closed 2 years ago

rajsite commented 2 years ago

While integrating beachball an upgrade to the the dependencies caused the smoke test to fail for @angular-eslint/template/i18n.

The rule was disabled for the smoke test and should be re-enabled: https://github.com/ni/javascript-styleguide/blob/5d549a4a9b0377dd3d32e18ea44fc60e27395615/tests/angular/.eslintrc.js#L19

rajsite commented 2 years ago

@scotia673 do you know the syntax to make that rule pass in that smoke test? Would love a PR if you know off the top :D (I should learn it eventually but today isn't that day)

scotia673 commented 2 years ago

I assume this rule is just enforcing that i18n is used here? If so, then I believe the syntax would be template: 'Hello <span i18n-id [(id)]="name">{{name}}</span>!'?