search

ni / javascript-styleguide

JavaScript and TypeScript Style Guide
MIT License
9 stars 9 forks source link

Rename NPM scripts to use colon syntax (lint:fix instead of lint-fix) #66

Closed jattasNI closed 3 years ago

jattasNI commented 3 years ago

In a PR comment, @TrevorKarjanis suggested using the : convention for grouping related NPM scripts. This seems to be a somewhat established convention so I propose we recommend it in our docs.

rajsite commented 3 years ago

Looks like for the package scripts in this repo the only offender is the publish-ci command: https://github.com/ni/javascript-styleguide/blob/53903a6ed1c8ab8177f4e76a9ef08e48d4a39428/package.json#L15

We could either modify it or remove it. I had trouble getting auto-publishing on the CI with beachball working and probably won't spend time on it for a while (must have missed it when reverting the changes).

jattasNI commented 3 years ago

Looks like for the package scripts in this repo the only offender is the publish-ci command: We could either modify it or remove it.

@rajsite I opted to modify it.