ni / javascript-styleguide

JavaScript and TypeScript Style Guide

MIT License

9 stars 9 forks source link

Re-enable i18n in Angular smoke test #78

Closed rajsite closed 2 years ago

rajsite commented 2 years ago

Pull Request

🤨 Rationale

Fixes #64

👩‍💻 Implementation

Updated smoke test eslint config to remove the disable
Added the i18n attribute to the span and makes sure all text is contained in an element with an i18n attribute.

🧪 Testing

Ran tests locally

✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.