Open jattasNI opened 2 years ago
General agreement at our meeting today that we can solve most of this with documentation. For issue 3 above, adding an override for karma*.js
which turns off a couple rules seems preferable, but we'd be fine with docs if we run into issues with that approach.
In this Skyline PR I enabled linting for the JS files in an Angular project. This situation is common because of config files like
karma.conf.js
and.eslintrc.js
. I hit a couple small bumps that would be nice to address in this repo..eslintrc.js
to use the JavaScript ruleset for files matching*.js
. We should either document this as our recommended approach or change our Angular and TS rulesets to apply to JS files too.angular.json
lintFilePatterns
to include*.js
since thenpm run lint
command calledng lint
. We should document this.karma.conf.js
generated by Angular. I chose to suppress those rules. In another case we chose to fix them (see discussion in linked PR). It would be nice to settle on a preferred approach and include guidance in our repo since most projects will likely hit the same errors.karma.conf.js