search

ni / linux

Linux kernel source for NI Linux Real-Time
Other
80 stars 77 forks source link

Add Netconsole Support as a Module #113

Closed aeshra closed 1 year ago

bstreiff commented 1 year ago

Hi @aeshra,

I see a couple problems with this commit:

  1. commit style - we follow the upstream Linux style standards for commits, which means
    • commit should have a subject line that indicates what subsystem it modifies and a short summary
    • commit should have a short description describing what it's doing and why
    • commit should be properly Signed-off-by.
    • for examples of defconfig updates specifically, look at baa47c510cd3 or 9f2c2bbbbfc5e6
  2. the lines that you've added look to be out of order. The usual flow for making a change to defconfigs would be:
    • make nati_x86_64_defconfig
    • (make your changes to .config either via a text editor, make menuconfig, or what have you)
    • make savedefconfig
    • cp defconfig arch/x86/configs/nati_x86_64_defconfig

Please correct these and then submit an update to this PR. Thanks!

aeshra commented 1 year ago

Hello @bstreiff,

Thanks for your patience, it is my first time submitting a request.

I have made another pull request with the correct procedure https://github.com/ni/linux/pull/114, and will close this one after the other one is approved.

Thanks for your help.

bstreiff commented 1 year ago

For future reference: You can force-push into your own branch (the patch-1 branch on aeshra/linux) to replace the commits in the PR there, and that updates this PR. It's not necessary to create a new PR for each revision.

I'll close this one and we can continue in #114.