search

ni / linux

Linux kernel source for NI Linux Real-Time
Other
80 stars 77 forks source link

Revert "usb: dwc3: gadget: Add 1ms delay after end transfer command without IOC" #133

Closed chaitu236 closed 1 year ago

chaitu236 commented 1 year ago

This reverts commit 1450c82a16bba232dca0ff667b17c0970ddecb85.

That commit caused usblan to not work reliably between some cRIOs (903x, 9041) and windows host. The issue happens only sometimes and when it happens, windows host would report the network adapter as unconnected. The only way to reliably recover from this was to reconnect usb cable or disable and enable windows network adapter. Rebooting the cRIO would also sometimes fix the issue.

Natinst-AzDo-ID: 2419039

Testing

Note

I intend to create a tech debt item to fix the original commit (if possible) and upstream it.

chaitu236 commented 1 year ago

I think the revert is OK but the commit message (for the revert) could use a bit of improvement so we can reason about it in the future.

Can you add a tag with the bug number, something like "Natinst-AzDo-ID" or something like that? And maybe a bit more context in the commit message?

Added some more context and the bug id. Let me know if this is ok.