ni / measurement-plugin-labview

LabVIEW framework to develop measurement plug-ins for NI application software. Contains sample measurement plug-ins for InstrumentStudio and TestStand and a generator with a measurement template to get started on a measurement plug-in.

MIT License

10 stars 13 forks source link

MeasurementLink Client LabVIEW example frequently crashes. #485

Closed ccaltagi closed 3 months ago

ccaltagi commented 7 months ago

Bug Report

I am trying to run the shipping MeasurementLink Client example by first running `Run Service.vi` in `Service.lvproj` then `Run Client.vi` in `Client.lvproj`, but this crashes very frequently.

I am attaching the crash reports.

Run the example from measurementlink-labview-examples-2.0.0.1\MeasurementLink Client

Expected Behavior

The example should not crash.

Current Behavior

The example crashes when running the client. Attaching the stack trace.

Context

Evaluation of adding MeasurementLink support to FlexLogger.

Your Environment

OS & Device: Windows 11
ni-measurement-service version 2.0.0.1
MeasurementLink version 2024 Q1
LabVIEW gRPC Library 1.2.0.1

8b8a5ea8-93d6-4c56-a520-276ba41bf2fc.zip 3401af17-584c-45dd-9e00-8d4033496da2.zip

AB#2659707

dixonjoel commented 7 months ago

@ccaltagi I noticed you have the 1.2.0.1 version of LabVIEW gRPC Library. We depend on the 1.0.1.1 version (see the assets in our release here). I'd suggest trying with that version to see if it still crashes. I ran the client several times on my machine here without crashing.

I just finished installing LabVIEW gRPC 1.2.0.1 and it also crashed for me.

ccaltagi commented 7 months ago

Thanks! Downgrading to gRPC 1.0.1.1 fixed the crash.

dixonjoel commented 7 months ago

@CPattar-NI The 1.2.0.1 release seems to have broken this. We looked through the changes and suspect maybe https://github.com/ni/grpc-labview/pull/335 could be the culprit. Would you take a look at this?

From the client code that is crashing, it's calling EnumerateServices on the discovery service. In the code below, that call is actually unnecessary since it's not using the result of the call. So perhaps it could be related to unwired outputs?

nischalks commented 6 months ago

This is now fixed and is available as part of this release https://github.com/ni/grpc-labview/releases/tag/v1.2.2.1

dixonjoel commented 3 months ago

Closing as the fix has been verified.