search

ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
428 stars 154 forks source link

Add Counter Stream Writer tests #533

Closed zhindes closed 6 months ago

zhindes commented 6 months ago

What does this Pull Request accomplish?

This ensures we have a test per method of the Counter stream writer classes. These tests use digital loopback to validate that the data made it all the way through the Python/C bindings correctly to the underlying driver.

Why should this Pull Request be merged?

This will give us confidence that we haven't broken anything as we refactor parts of the Python / C bindings.

What testing has been done?

poetry run ni-python-styleguide fix tests && poetry run ni-python-styleguide lint tests && poetry run pytest -rs -k test_stream_writers_co
===================================== test session starts ======================================
platform win32 -- Python 3.9.13, pytest-8.0.2, pluggy-1.4.0
rootdir: C:\dev\nidaqmx-python
configfile: pyproject.toml
testpaths: tests
plugins: cov-4.1.0, mock-3.12.0
collected 2033 items / 2003 deselected / 30 selected

tests\component\test_stream_writers_co.py ..............................                  [100%]

============================= 30 passed, 2003 deselected in 4.81s ==============================
github-actions[bot] commented 6 months ago

Test Results

    30 files  ±  0      30 suites  ±0   38m 28s :stopwatch: -9s  2 034 tests + 30   1 667 :white_check_mark: ±0    367 :zzz: + 30  0 :x: ±0  32 190 runs  +450  26 810 :white_check_mark: ±0  5 380 :zzz: +450  0 :x: ±0 

Results for commit f306216a. ± Comparison against base commit 2c18e565.