search

ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
428 stars 154 forks source link

Update cfg analog multi edge trig APIs #535

Closed WayneDroid closed 5 months ago

WayneDroid commented 6 months ago

What does this Pull Request accomplish?

Updated CfgAnlgMultiEdgeRefTrig and CfgAnlgMultiEdgeStartTrig metadata and generated the APIs.

Why should this Pull Request be merged?

Enable CfgAnlgMultiEdgeRefTrig and CfgAnlgMultiEdgeStartTrig APIs for the 1.0 release.

What testing has been done?

Add test cases:

image image image image

WayneDroid commented 6 months ago

are tests coming in this PR or another one?

tests will be added in this PR.

WayneDroid commented 5 months ago

are tests coming in this PR or another one?

test cases are added.

WayneDroid commented 5 months ago

@zhindes can this PR go in or do I need to wait for the actual fix on the metadata?

zhindes commented 5 months ago

@zhindes can this PR go in or do I need to wait for the actual fix on the metadata?

It can go in, that's gonna be a slow roll.