Closed charitylxy closed 5 months ago
This PR aims to address issue brought up in https://github.com/ni/nidaqmx-python/issues/461:
nidaqmx._task_modules
task.py
Refactoring work will be split into 5 PRs:
_task.py
_in_stream.py
_export_signal.py
_out_stream.py
_timing.py
_channel_collection.py
_ai_channel_collection.py
_ao_channel_collection.py
_ci_channel_collection.py
_co_channel_collection.py
_di_channel_collection.py
_do_channel_collection.py
_channel.py
_ai_channel.py
_ao_channel.py
_ci_channel.py
_co_channel.py
_di_channel.py
_do_channel.py
_triggers.py
_arm_start_trigger.py
_handshake_trigger.py
_pause_trigger.py
_reference_trigger.py
_start_trigger.py
In this PR to address https://github.com/ni/nidaqmx-python/issues/461, following changes have been made:
channels
task
tests/component/_task_modules
tests/component/task
tests
Ran poetry run pytest and all tests passed.
poetry run pytest
What does this Pull Request accomplish?
This PR aims to address issue brought up in https://github.com/ni/nidaqmx-python/issues/461:
nidaqmx._task_modules
package.task.py
into a package and merge it with the internal modules contained innidaqmx._task_modules
Refactoring work will be split into 5 PRs:
_task.py
and_in_stream.py
- https://github.com/ni/nidaqmx-python/pull/534_export_signal.py
,_out_stream.py
,_timing.py
- https://github.com/ni/nidaqmx-python/pull/539_channel_collection.py
,_ai_channel_collection.py
,_ao_channel_collection.py
,_ci_channel_collection.py
,_co_channel_collection.py
,_di_channel_collection.py
,_do_channel_collection.py
- https://github.com/ni/nidaqmx-python/pull/541_channel.py
,_ai_channel.py
,_ao_channel.py
,_ci_channel.py
,_co_channel.py
,_di_channel.py
,_do_channel.py
_triggers.py
,_arm_start_trigger.py
,_handshake_trigger.py
,_pause_trigger.py
,_reference_trigger.py
,_start_trigger.py
Why should this Pull Request be merged?
In this PR to address https://github.com/ni/nidaqmx-python/issues/461, following changes have been made:
channels
totask
package and made its modules private.tests/component/_task_modules
renamed totests/component/task
.tests
.What testing has been done?
Ran
poetry run pytest
and all tests passed.