ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
413 stars 155 forks source link

After the fact feedback from PR #558 #564

Closed texasaggie97 closed 3 months ago

texasaggie97 commented 3 months ago

There was feedback that came in after #558 was completed. This handles that feedback.

What does this Pull Request accomplish?

What testing has been done?

PR

github-actions[bot] commented 3 months ago

Test Results

    34 files  ±0      34 suites  ±0   47m 22s :stopwatch: + 4m 2s  2 248 tests ±0   1 910 :white_check_mark: ±0    338 :zzz: ±0  0 :x: ±0  39 690 runs  ±0  34 134 :white_check_mark: ±0  5 556 :zzz: ±0  0 :x: ±0 

Results for commit 97c5eb99. ± Comparison against base commit 06da4f46.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. ``` tests.component.test_task_events ‑ test___done_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs] tests.component.test_task_events ‑ test___done_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[library_init_kwargs] tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs] tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[library_init_kwargs] ``` ``` tests.component.test_task_events ‑ test___done_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs] tests.component.test_task_events ‑ test___done_event_registered___call_stop_close_in_callback___task_closed_with_success_status[library_init_kwargs] tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs] tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_stop_close_in_callback___task_closed_with_success_status[library_init_kwargs] ```
This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both. ``` tests.component.test_task_events ‑ test___done_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs] tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_clear_in_callback___stop_close_in_callback_with_success_status[grpc_init_kwargs] ``` ``` tests.component.test_task_events ‑ test___done_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs] tests.component.test_task_events ‑ test___every_n_samples_event_registered___call_stop_close_in_callback___task_closed_with_success_status[grpc_init_kwargs] ```