ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
413 stars 155 forks source link

Incomplete timestamp support - missing attributes and wait_for_valid_timestamp isn't returning a value #591

Closed zhindes closed 1 month ago

zhindes commented 1 month ago

In the round of updates for 1.0, we missed a batch of attributes and functionality related to timestamps. In particular these attributes listed in attribute_helpers.py exclusion list should be supported:

    "ARM_START_TRIG_TIMESTAMP_VAL",
    "REF_TRIG_TIMESTAMP_VAL",
    "START_TRIG_TIMESTAMP_VAL",
    "FIRST_SAMP_CLK_OFFSET",
    "FIRST_SAMP_CLK_TIMESCALE",
    "FIRST_SAMP_CLK_WHEN",
    "FIRST_SAMP_TIMESTAMP_VAL",
    "SYNC_PULSE_TIME_WHEN",
    "TIMING_SYNC_PULSE_FORCE", # Note: not this one, this is unrelated and isn't actually supported by any DAQmx devices. Strange.
    "ARM_START_TRIG_TIMESTAMP_VAL",
    "REF_TRIG_TIMESTAMP_VAL",
    "START_TRIG_TIMESTAMP_VAL",

While investigating this, @bkeryan noticed a similar issue that is related - task.wait_for_valid_timestamp isn't returning a value. Both the gRPC interpreter and the library interpreter are correctly returning a datetime object.