search

ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
443 stars 157 forks source link

GitHub: Run unit tests with pypy #625

Closed bkeryan closed 2 months ago

bkeryan commented 2 months ago

What does this Pull Request accomplish?

Update the GitHub workflows to run unit tests with PyPy.

The list of version numbers is based on what's currently available on the GitHub ubuntu-latest and windows-latest runner images.

Why should this Pull Request be merged?

This project doesn't run any automated tests with PyPy.

What testing has been done?

PR build

github-actions[bot] commented 2 months ago

Test Results

   11 files   -     23     11 suites   - 23   4m 17s :stopwatch: - 47m 32s   210 tests  -  2 138    210 :white_check_mark:  -  1 784  0 :zzz:  -   354  0 :x: ±0  2 310 runs   - 39 962  2 310 :white_check_mark:  - 33 710  0 :zzz:  - 6 252  0 :x: ±0 

Results for commit 26ca6d86. ± Comparison against base commit 56feb618.

This pull request removes 2138 tests. ``` tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path0] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path10] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path11] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path12] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path13] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path14] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path15] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path16] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path17] tests.acceptance.test_examples ‑ test___shipping_example___run___no_errors[library_init_kwargs-example_path18] … ```
bkeryan commented 2 months ago

Simply enabling pypy support is not enough, so I filed an issue: https://github.com/ni/nidaqmx-python/issues/626

"And all our best-laid plans, they crumbled in our hands" --Okkervil River, "The Velocity of Saul at the Time of His Conversion"