search

ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
447 stars 161 forks source link

[releases/1.0] Merge 1.0.1 changes into release branch #632

Closed bkeryan closed 2 months ago

bkeryan commented 2 months ago

What does this Pull Request accomplish?

Fast-forward merge the 1.0.1 changes into the releases/1.0 branch.

Why should this Pull Request be merged?

1.0.1 was released out of the wrong branch: it was released out of master, not releases/1.0. As a result, none of the 1.0.1 changes were cherry-picked to releases/1.0 prior to release.

We ought to release out of the release branches so that we can commit changes for the next release to master, but in this case there were no such changes, so let's just fix up the release branch.

What testing has been done?

None

github-actions[bot] commented 2 months ago

Test Results

    34 files  +    24      34 suites  +24   51m 56s :stopwatch: + 48m 47s  2 348 tests + 2 138   1 994 :white_check_mark: + 1 784    354 :zzz: +  354  0 :x: ±0  42 272 runs  +40 172  36 020 :white_check_mark: +33 920  6 252 :zzz: +6 252  0 :x: ±0 

Results for commit 79df1b10. ± Comparison against base commit 53db026c.

:recycle: This comment has been updated with latest results.

bkeryan commented 2 months ago

The checks were waiting for CI / Generate docs instead of CI / Generate docs / Generate docs. I updated the repo's required checks and closed/reopened the review. I hope this fixes it.